Skip to content

Commit 3c2afba

Browse files
gvaibhav1734ashishkumar468
authored andcommitted
Fix NullPointer when clicking on image in MediaDetailFragment (commons-app#3730) (commons-app#3738)
Uri.parse would throw NullPointerException if the image in MediaDetailFragment was clicked before the image URL is available
1 parent 461249f commit 3c2afba

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -209,10 +209,12 @@ && getParentFragment() instanceof MediaDetailPagerFragment) {
209209

210210
@OnClick(R.id.mediaDetailImageViewSpacer)
211211
public void launchZoomActivity(View view) {
212-
Context ctx = view.getContext();
213-
ctx.startActivity(
214-
new Intent(ctx,ZoomableActivity.class).setData(Uri.parse(media.getImageUrl()))
215-
);
212+
if (media.getImageUrl() != null) {
213+
Context ctx = view.getContext();
214+
ctx.startActivity(
215+
new Intent(ctx, ZoomableActivity.class).setData(Uri.parse(media.getImageUrl()))
216+
);
217+
}
216218
}
217219

218220
@Override

0 commit comments

Comments
 (0)