Fix NullPointer when clicking on image in MediaDetailFragment (#3730) #3738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3738 +/- ##
===========================================
- Coverage 7.38% 7.38% -0.01%
Complexity 340 340
===========================================
Files 290 290
Lines 12821 12822 +1
Branches 1004 1004
===========================================
Hits 947 947
- Misses 11799 11800 +1
Partials 75 75
Continue to review full report at Codecov.
|
ashishkumar468
approved these changes
May 8, 2020
|
Fixes the issue for me, thanks for the PR @gvaibhav1734 |
ashishkumar468
pushed a commit
to ashishkumar468/apps-android-commons
that referenced
this pull request
May 8, 2020
…s-app#3730) (commons-app#3738) Uri.parse would throw NullPointerException if the image in MediaDetailFragment was clicked before the image URL is available
ashishkumar468
pushed a commit
to ashishkumar468/apps-android-commons
that referenced
this pull request
Oct 10, 2020
…s-app#3730) (commons-app#3738) Uri.parse would throw NullPointerException if the image in MediaDetailFragment was clicked before the image URL is available
ashishkumar468
pushed a commit
to ashishkumar468/apps-android-commons
that referenced
this pull request
Oct 10, 2020
…s-app#3730) (commons-app#3738) Uri.parse would throw NullPointerException if the image in MediaDetailFragment was clicked before the image URL is available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3730
What changes did you make and why?
Added a null check to prevent Null Pointer Exception when user clicks on image in MediaDetailFragment.
Tests performed (required)
Tested on {prodDebug, betaDebug} on {Pixel 2 emulator} with API level {28}.