Added Font & Font Weight Support#100
Closed
kylestetz wants to merge 1 commit intoaterrien:masterfrom
kylestetz:master
Closed
Added Font & Font Weight Support#100kylestetz wants to merge 1 commit intoaterrien:masterfrom kylestetz:master
kylestetz wants to merge 1 commit intoaterrien:masterfrom
kylestetz:master
Conversation
|
Why hasn't this been merged? Specifying fonts, and font-weight is important. Size is pretty important too. Should be able to take in a class to be honest. Very odd. |
aterrien
pushed a commit
that referenced
this pull request
Sep 2, 2013
aterrien
pushed a commit
that referenced
this pull request
Sep 2, 2013
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added
fontandfontWeightparameters to the defaults, pointing them to data attributes following your pattern.You can add
data-font='Helvetica'anddata-font-weight='bold'in the HTML tag or pass it into the knob in Javascript:$('.knob').knob({ font: 'Helvetica', fontWeight: 'bold' })