Fire change event when user types in a new value or uses arrow keys#102
Open
xilocex wants to merge 2 commits intoaterrien:masterfrom
Open
Fire change event when user types in a new value or uses arrow keys#102xilocex wants to merge 2 commits intoaterrien:masterfrom
xilocex wants to merge 2 commits intoaterrien:masterfrom
Conversation
|
I added this @line: 166: s.cH(s.$.val()); to make the input value trigger the change event. Now it works great passing the input value to the callback. |
|
@xilocex @j8 These fixes worked, but if you type more than the maximum amount of digits in the input field then the change event still won't fire (and the dial won't draw, either). e.g. if you have set a max of 99 (2 digits) and you type 100 (3 digits), then it will clamp to 99 but when the input field loses focus the change event doesn't fire and the dial won't redraw. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added s.cH(s.$.val()); @line: 146 so that the change event is fired when a user types in a new value for the input.
This was pursued in response to Issue #89
Added s.cH(v); @line: 511 so that the change event is fired when a user has the input focused and is using the arrow keys.