Add option 'scroll' to disable scrolling#135
Open
artuze wants to merge 3 commits intoaterrien:masterfrom
Open
Conversation
added 3 commits
November 1, 2013 11:06
There was a problem hiding this comment.
Thanks @artuze, this is a useful feature.
However this line seems to cause scroll to always evaluate true and therefore the option does not work.
This should work the way intended:
scroll : this.$.data('scroll') == null || this.$.data('scroll'),
👍 for adding this option, had the same problem with the dial interfering with scrolling.
|
any chance to add this option? |
dazwin
added a commit
to kwaaioak/jQuery-Knob
that referenced
this pull request
Aug 17, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On longer pages where the control isn't going to be obvious, scrolling past it tends to stop the page scroll and change the value on the control.
I added a quick boolean option
scrollwhich defaults to true that is used as a conditional for the calls to bind to the mousewheel. This does have the unfortunate effect of disabling the ability to use the mousewheel on the dial completely.(Also, hi. First pull-request ever, so I hope I'm doing this somewhat right, and if not, sorry, and feel free to ignore it. 😄 )