Skip to content

added data-unit option to display input#158

Open
greglbd wants to merge 4 commits intoaterrien:masterfrom
greglbd:master
Open

added data-unit option to display input#158
greglbd wants to merge 4 commits intoaterrien:masterfrom
greglbd:master

Conversation

@greglbd
Copy link

@greglbd greglbd commented Jan 14, 2014

this might be useful, i've seen a few people ask for this feature.

@greglbd
Copy link
Author

greglbd commented Jan 17, 2014

@mohammadshaker did you use the code as is or make any changes?
can you show me your code and i can try to debug?

If you used it as is, what OS/Browser combination?

@greglbd
Copy link
Author

greglbd commented Jan 17, 2014

@mohammadshaker someone in our office over here managed to replicate your bug. A fix has been pushed.

@winwaed
Copy link

winwaed commented Jan 30, 2014

Yes very useful. Will this be going in the next release?
I used this approach: http://stackoverflow.com/questions/18955708/how-to-display-units-with-jquery-knob
but it also suffered from the multiple '%' characters. This is easily fixed with a parseInt() however refreshes also resulted in the colored arc being lost. The fix is to validate the value (which is probably a good idea anyway) - I'll post this change.

@greglbd
Copy link
Author

greglbd commented Feb 8, 2014

@winwaed, I made a pull request to @aterrien but haven't heard anything as yet....I hope it goes in the next release as i'm using it in some projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments