Numeric validation for the colored foreground arc#167
Open
winwaed wants to merge 1 commit intoaterrien:masterfrom
Open
Numeric validation for the colored foreground arc#167winwaed wants to merge 1 commit intoaterrien:masterfrom
winwaed wants to merge 1 commit intoaterrien:masterfrom
Conversation
It is possible for the data value to include non-numeric characters. This happens explicitly with modifications such as: http://stackoverflow.com/questions/18955708/how-to-display-units-with-jquery-knob This modification works well for the label, but the addition of the '%' character causes the arc not to be displayed when the page is refreshed. The above fixes this and removes all non-number characters from the value before attempting to plot it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is possible for the data value to include non-numeric characters. This happens explicitly with modifications such as: http://stackoverflow.com/questions/18955708/how-to-display-units-with-jquery-knob
This modification works well for the label, but the addition of the '%' character causes the arc not to be displayed when the page is refreshed. The above fixes this and removes all non-number characters from the value before attempting to plot it.