Open
Conversation
bound a listener for an `update` event which calls the `val` method with the second param as `false` so as not to trigger the release handler. this is useful when we create a knob that we update periodically as well expect the user to interact with at the same time e.g. an audio scrubber which shows the track progress which you can change as well.
added a `scrubbing` flag which prevents the `val` function from overwriting the `cv` variable when the user is scrubbing, this stops a flickering issue when the user is scrubbing but the `val` get's updated in the processes temporarily when the `cv` value gets overwritten.
added triggering of change handler when using mouse wheel to change values
Owner
|
I'm about to merge these features (about "scrubbing" flag, it's more clear for me now:)) and it would be nice if you could add some lines in README.md and an example in index.html. |
|
+1 for both pull requests, expecially for the "scrubbling" one. I already tested its integration in RuneAudio's UI and it works as expected. Great work @HaykoKoryun! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added two new functions:
boundswhich checks to see if the event was within the circular bounds of the knobpropagatewhich propagates the event to any other elements underneath the canvas, really useful for stacking knobs