added support for linear gradient on foreground to span the amount vi…#326
Open
banjahman wants to merge 1 commit intoaterrien:masterfrom
Open
added support for linear gradient on foreground to span the amount vi…#326banjahman wants to merge 1 commit intoaterrien:masterfrom
banjahman wants to merge 1 commit intoaterrien:masterfrom
Conversation
Author
|
@aterrien what needs done here to test and merge this? My implementation of this relies on these gradients. |
| var gwidth = perc === 100 ? this.w : (this.w * perc); | ||
| var grad = c.createLinearGradient(0, this.h, gwidth, this.h); | ||
| grad.addColorStop(0, this.o.fgGradientStart); | ||
| grad.addColorStop(1, this.o.fgGradientEnd); |
Owner
There was a problem hiding this comment.
I think that gwidth formula will be better like that (in case of negative this.o.min) :
var gwidth = (((this.cv - this.o.min) * this.w) / (this.o.max - this.o.min));
Using this.cv allows to change color dynamically.
The result is cool but why use gradients instead of changing the fgcolor of the entire circle while changing value ? with new props fgColorMin, fgColorMax for example ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fit what I needed perfectly, however I'm using with arc and offset and need a gradient to cover the foreground