Added more support for HTML5 input elements, added allowFractions option#77
Open
odbol wants to merge 5 commits intoaterrien:masterfrom
Open
Added more support for HTML5 input elements, added allowFractions option#77odbol wants to merge 5 commits intoaterrien:masterfrom
odbol wants to merge 5 commits intoaterrien:masterfrom
Conversation
…ctions option to avoid rounding the result for higher-precision results
|
Hi. So, I copied your changes and then set the knobs' values (and max parameters) to be fractions, but the knobs still were rounded. |
|
Also, the circular bar that fills according to the value stopped showing. |
Author
|
Oops, sorry about that @YOMorales . Should be fixed now. |
Author
|
Oh but I don't think it will automatically turn to fractions if you use fractions in the min and max. Maybe you could add that in? |
|
I have done some hacks in the past weeks (mostly for a commercial project I'm working); let me see when I can cleanup them and push them here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for HTML5 input attributes like min, max.
Added allowFractions option to avoid rounding the result for higher-precision results.
Added a CSS class to the wrapper element so it can be styled easier.