Added width property to selection plugin.#11
Merged
daffl merged 2 commits intobitovi:masterfrom Jun 8, 2012
Merged
Conversation
daffl
added a commit
that referenced
this pull request
Jun 8, 2012
Added width property to selection plugin.
Contributor
|
Awesome thanks! The width makes sense and the tests were actually failing before (don't know why it slipped through). All working now, will be in the next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a width property to the object returned by
$(el).selection(). Doesn't have any significant performance impact, so can't see any harm in adding it.I also rewrote the test, as it was randomly failing sometimes.