Skip to content

Force hover leave on new mouseenter. Fixes #63 and #64. #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daffl merged 1 commit into from
Feb 6, 2013
Merged

Force hover leave on new mouseenter. Fixes #63 and #64. #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 26 additions & 3 deletions event/hover/hover.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,11 +110,28 @@ steal('jquery', 'jquery/event/livehack', function ($) {
// now start checking mousemoves to update location
var delegate = ev.delegateTarget || ev.currentTarget;
var selector = ev.handleObj.selector;
var pending = $.data(delegate,"_hover"+selector);
// prevents another mouseenter until current has run its course
if ($.data(delegate, "_hover" + selector)) {
if(pending) {
// Under some circumstances, mouseleave may never fire
// (e.g., the element is removed while hovered)
// so if we've entered another element, wait the leave time,
// then force it to release.
if(!pending.forcing) {
pending.forcing = true;
clearTimeout(pending.leaveTimer);
var leaveTime = pending.leaving ?
Math.max(0,pending.hover.leave - (new Date() - pending.leaving)) :
pending.hover.leave;
var self = this;

setTimeout(function() {
pending.callHoverLeave();
onmouseenter.call(self,ev);
},leaveTime);
}
return;
}
$.data(delegate, "_hover" + selector, true)
var loc = {
pageX : ev.pageX,
pageY : ev.pageY
Expand Down Expand Up @@ -158,7 +175,8 @@ steal('jquery', 'jquery/event/livehack', function ($) {
} else {
clearTimeout(leaveTimer);
// leave the hover after the time set in hover.leave(time)
leaveTimer = setTimeout(function () {
pending.leaving = new Date();
leaveTimer = pending.leaveTimer = setTimeout(function(){
callHoverLeave();
}, hover._leave)
}
Expand All @@ -178,6 +196,11 @@ steal('jquery', 'jquery/event/livehack', function ($) {
})
hovered = true;
};
pending = {
callHoverLeave: callHoverLeave,
hover: hover
};
$.data(delegate,"_hover"+selector, pending);

// Bind the mousemove event
$(enteredEl).bind("mousemove", mousemove).bind("mouseleave", mouseleave);
Expand Down