Update jquery.storelocator.js #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JimmyRittenborg
commented
Jul 17, 2013
- Possibility to add custom variables in locations (Now extended to KML source)
- Allowing originMarker regardless of fullMapStart has been set
- Adds originMarker to bounds, when zoomLevel is 0, to give a better context of distance
- Possibility to add custom variables in locations (Now extended to KML source) - Allowing originMarker regardless of fullMapStart has been set - Adds originMarker to bounds, when zoomLevel is 0, to give a better context of distance
Contributor
Author
|
I couldn't wrap my head around taking the user to the nearest location if the max distance is exceeded, like the Starbucks Store Locator does it - so thats the reason for my changes about the originMarker at least, to improve the current user experience a bit. Especially on mobile where chances are small of having the list of stores and the map in same view. |
Contributor
Author
|
Now it should be good to go :) |
bjorn2404
added a commit
that referenced
this pull request
Jul 23, 2013
Update jquery.storelocator.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.