Skip to content
This repository was archived by the owner on May 25, 2023. It is now read-only.

Bring back support for Node/CommonJS #3509

Merged
merged 1 commit into from
Jun 19, 2018

Conversation

bbc2
Copy link
Contributor

@bbc2 bbc2 commented Jun 18, 2018

Browserify, which follows CommonJS module conventions, parses the AST for require calls to determine the dependencies of a project.

jQuery File Upload used to support this; it was removed in e2cda46 when a new version of jquery.ui.widget.js was vendored.

@blueimp
Copy link
Owner

blueimp commented Jun 19, 2018

Thanks for the heads up @bbc2.
I have just one change request before merging this:
Could you add +CommonJS behind the version number in the jQuery UI Widget source file?
The first line would then look like this:

/*! jQuery UI - v1.12.1+CommonJS - 2018-02-10

Browserify, which follows CommonJS module conventions, parses the AST
for `require` calls to determine the dependencies of a project.

jQuery File Upload used to support this; it was removed in
e2cda46 when a new version of
jquery.ui.widget.js was vendored.
@bbc2 bbc2 force-pushed the widget-browserify-support branch from 3717dc9 to b69c7db Compare June 19, 2018 07:25
@bbc2
Copy link
Contributor Author

bbc2 commented Jun 19, 2018

No problem, just did that.

@blueimp blueimp merged commit b110bc6 into blueimp:master Jun 19, 2018
@blueimp
Copy link
Owner

blueimp commented Jun 19, 2018

Thanks!

@bbc2 bbc2 deleted the widget-browserify-support branch June 19, 2018 09:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants