Got it working with new cacheable-flash gem

[pboling]

No description provided.

[carhartl]

Looking at the diff I can't understand how these changes help to make it work with that gem... could you explain?

[pboling]

Perhaps a better way to say it is, 'a few features were added which are utilized by the cacheable-flash gem, and one bug was fixed, in the expiry date'.

[carhartl]

How is this different from the original code? t === options.expires.

[pboling]

You are correct, there is no functional difference. It would be clearer if t were removed altogether. I had misremembered the purpose of the change (which I had pulled from another fork).

                var days = options.expires;
                options.expires.setDate(new Date().getDate() + days);

[carhartl]

It was just to save some code. Otherwise I had to write (your code is missing something):

var days = options.expires;
options.expires = new Date();
options.expires.setDate(option.expires.getDate() + days);

[carhartl]

Something like the following doesn't make it much better I think...

options.expires = new Date(new Date() * 1 + options.expires * 24 * 60 * 60 * 1000);

[pboling]

Agreed. :)

[carhartl]

Is there a github issue at play? When I look at the Diff, the only (relevant) difference I see is this:

-            t.setDate(t.getDate() + days);
+            options.expires.setDate(t.getDate() + days);

which still doesn't do much.

[pboling]

This is not dissimilar from the other pull request from @benz303. It looks like the differences are either already part of your master or also included in that other pull request. I am closing this one.