Commonjs export fix and jshint updates#339
Conversation
|
What does this PR solves exactly and how is the current behavior without your PR? |
|
It didn't properly export the module before, meaning a |
|
You mean it did not exported correctly in a nodeJS environment, correct? The factory doesn't return anything, so the return value would not be of any use if that's what you're looking for. You say the inclusion of |
|
This is commonjs standard, wether it's for node or browserify that shouldn't matter. In commonjs the module is not returned, it is attached to the module object, which is why in umd we're looking for exports |
Commonjs export fix and jshint updates
Seems like the commonjs export wasn't working. This PR fixed it for me.