This repository was archived by the owner on Nov 15, 2017. It is now read-only.
Add expires for midnight.#354
Closed
istickz wants to merge 1 commit intocarhartl:masterfrom
istickz:patch-1
Closed
Add expires for midnight.#354istickz wants to merge 1 commit intocarhartl:masterfrom istickz:patch-1
istickz wants to merge 1 commit intocarhartl:masterfrom
istickz:patch-1
Conversation
Add expires for midnight.
Use:
$.cookie('key', "value", { expires: 'midnight' });
Collaborator
|
We would like to avoid cluttering the codebase by abstracting the date definitions in strings. You should handle the midnight rule externally and provide a proper date instance with the desired value. |
Owner
|
Agreeing, and closing. Thanks for the PR nonetheless! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add expires for midnight.
Use:
$.cookie('key', "value", { expires: 'midnight' });