This repository was archived by the owner on Nov 15, 2017. It is now read-only.
Clarified usage of json property#396
Closed
UpperAvenue wants to merge 2 commits intocarhartl:masterfrom
Closed
Conversation
added 2 commits
August 19, 2016 09:33
The line "Assumes 'JSON.stringify' and 'JSON.parse'" could be interpretted as it assumes the user performs these actions before passing them to $.cookie, rather than it assumes the task of performing these actions when $.cookie is called.
Collaborator
|
This repository is frozen and not accepting new change requests. Please refer to: Can we open this PR in the new repo so that we can discuss there? Thanks! |
|
I think this should be closed now. |
Collaborator
|
X-ref: #392 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The line "Assumes 'JSON.stringify' and 'JSON.parse'" could be interpreted as: Assumes the user executes these functions before passing$.cookie the data. Rather than Assumes the task of executing these functions when $ .cookie is called.