Skip to content
This repository was archived by the owner on Nov 15, 2017. It is now read-only.

added minified version#71

Closed
sdepold wants to merge 1 commit intocarhartl:masterfrom
sdepold:master
Closed

added minified version#71
sdepold wants to merge 1 commit intocarhartl:masterfrom
sdepold:master

Conversation

@sdepold
Copy link

@sdepold sdepold commented May 21, 2012

@cobexer
Copy link

cobexer commented May 21, 2012

Why are there always devs trying to get minified versions into source code repos??

@sdepold
Copy link
Author

sdepold commented May 22, 2012

because u want to download the repo and start working?

@cobexer
Copy link

cobexer commented May 22, 2012

@sdepold there are a few problems with this approach:

  1. if you use the minified version in your project, your doing it wrong because if you use a lot of minified scripts your site/app will need a lot of HTTP requests and thus be slow
  2. this is a source repo, binaries should be kept out of them (a pre-minified download in the downloads section would be the better approach IMHO)
  3. if you only use the minified version and find a bug, your bug-report will likely suck

and
4) I shouldn't annoy people in someone else's repo^^

@FagnerMartinsBrack
Copy link
Collaborator

I agree with the guy above.
Any project may have its own minify tools.
The best thing to do is to work in the pages with the unminified versions (production) and in the build gather all the imports into a single file and minify it.
There should be no reason to send a minified version of any single JS project in the rep, although it could be handy for those who don't care about debbugging, updating (usually when u are hired to create some random site), but even that way you could minify through some web app.

@Krinkle
Copy link
Contributor

Krinkle commented Jun 19, 2012

And most web applications do (or should have) some automated build mechanism already to mass-minify all your files for delivery in the production version of the site.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants