You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Nov 15, 2017. It is now read-only.
@sdepold there are a few problems with this approach:
if you use the minified version in your project, your doing it wrong because if you use a lot of minified scripts your site/app will need a lot of HTTP requests and thus be slow
this is a source repo, binaries should be kept out of them (a pre-minified download in the downloads section would be the better approach IMHO)
if you only use the minified version and find a bug, your bug-report will likely suck
and
4) I shouldn't annoy people in someone else's repo^^
I agree with the guy above.
Any project may have its own minify tools.
The best thing to do is to work in the pages with the unminified versions (production) and in the build gather all the imports into a single file and minify it.
There should be no reason to send a minified version of any single JS project in the rep, although it could be handy for those who don't care about debbugging, updating (usually when u are hired to create some random site), but even that way you could minify through some web app.
And most web applications do (or should have) some automated build mechanism already to mass-minify all your files for delivery in the production version of the site.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
was using http://closure-compiler.appspot.com/home