Skip to content
This repository was archived by the owner on Jan 17, 2025. It is now read-only.

Conversation

@ahmadbilaldev
Copy link
Contributor

Fixes #98

Description

I have made sure everything is up to date and works. All the changes mentioned do not essentially require any changes so far. This PR also updates the "Tested up to" field in readme to 5.4.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the master branch of the repository.
  • My commit messages follow best practices.
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@ahmadbilaldev ahmadbilaldev requested a review from a team as a code owner March 19, 2020 18:46
@ahmadbilaldev ahmadbilaldev requested a review from a team March 19, 2020 18:46
@kgodey
Copy link
Contributor

kgodey commented Mar 23, 2020

Thanks @ahmadbilaldev!

Copy link
Contributor

@hugosolar hugosolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Ahmad
I'm getting deprecated notifications in the browser console, I think is due to a change on the blocks API made in 5.4 (I couldn't find that information)

Screen Shot 2020-03-26 at 9 01 31 AM

Maybe if you change the const value on the blocks JS files it should work.

Screen Shot 2020-03-26 at 9 06 51 AM

@ahmadbilaldev
Copy link
Contributor Author

Hi Hugo,
I'll give it a check.

@hugosolar
Copy link
Contributor

Ok, this is fixed in #105

@hugosolar hugosolar closed this Apr 6, 2020
@TimidRobot TimidRobot deleted the tested-upto-5.4 branch November 19, 2020 23:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants