Skip to content
This repository was archived by the owner on Jan 17, 2025. It is now read-only.

Conversation

@Cronus1007
Copy link
Contributor

@Cronus1007 Cronus1007 commented Jan 30, 2021

Fixes

Fixes #108 by @hugosolar

Description

@hugosolar The files that have been moved to trash are due to the following reasons:-

  • Since all those files are dependent upon either wplicense.php or widgets/wplicense_widget.php which doesn't even exist. So these files just makes the codebase bulkier.
  • Plus for adding the internalization support for languages should be initiated not via writing files in my opinion but by providing the i18n support to php and en support by store/locales.json.
  • The package that I will like to automate the i18n process is zendframework/zend-i18n.

Technical details

Moved the files to trash which are dependent upon those files that doesn't exist eventually.

Tests

Screenshots

Screenshot from 2021-01-30 06-42-59

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Cronus1007 Cronus1007 requested a review from a team as a code owner January 30, 2021 01:13
Copy link
Contributor

@hugosolar hugosolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please provide more information in the PR, like a proper description and a proper screenshot (if it's necessary)
Also, you just remove the files but, are there any additional checks you made in case the plugin is still considering these files for any reason?
All of these details are needed in the PR description, please fill in

@Cronus1007 Cronus1007 requested a review from hugosolar February 26, 2021 08:36
Copy link
Contributor

@hugosolar hugosolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sense to me 👍

@hugosolar hugosolar merged commit 96d44d8 into cc-archive:master Mar 4, 2021
@TimidRobot TimidRobot added this to the v2021.04.1 milestone Apr 29, 2021
@Cronus1007 Cronus1007 deleted the move-trash branch May 24, 2021 13:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Remove outdated language files

3 participants