Skip to content
This repository was archived by the owner on Jan 17, 2025. It is now read-only.

Conversation

@nishantwrp
Copy link
Contributor

@nishantwrp nishantwrp commented Mar 7, 2021

Fixes

Fixes #[issue number] by @[issue author]

Description

Updates wpcs instructions to prevent error Getting PHPCS Response ERROR: Referenced sniff "PHPCSUtils" does not exist.

Technical details

Related to squizlabs/PHP_CodeSniffer#3110

Tests

Screenshots

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@nishantwrp nishantwrp requested a review from a team as a code owner March 7, 2021 12:19
@nishantwrp
Copy link
Contributor Author

@hugosolar ptal!

Comment on lines +90 to +95
After this you'll need to switch to the master branch of this repo.
```shell
cd wpcs
git checkout master
```

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nishantwrp Thanks for your contribution.But this is pretty obvious to start with a new repository.
@TimidRobot It is safe to close this pr for now.

Copy link
Contributor Author

@nishantwrp nishantwrp Apr 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Actually wpcs is the coding standard repository, not this one. Its default branch is develop. And it has some issues. Therefore we need to shift to the master branch manually.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend you to read the PR description before commenting anything.

@TimidRobot TimidRobot closed this Apr 29, 2021
@TimidRobot TimidRobot deleted the branch cc-archive:master April 29, 2021 17:04
@nishantwrp
Copy link
Contributor Author

nishantwrp commented Apr 29, 2021

@TimidRobot any particular reason to close this PR? I feel that this instruction should be pointed out in the CONTRIBUTING.md file because almost everyone gets stuck at that step while setting up this project.

@TimidRobot
Copy link
Contributor

@TimidRobot any particular reason to close this PR? I feel that this instruction should be pointed out in the CONTRIBUTING.md file because almost everyone gets stuck at that step while setting up this project.

@nishantwrp I'm not sure what happened 😖 I suspect I inadvertently caused this PR to be closed when I renamed the default branch. I can't reopen it because "The repository that submitted this pull request has been deleted."

I think the changes in the PR are helpful and I would be happy to merge them if they are resubmitted.

I'm sorry for the trouble.

@nishantwrp
Copy link
Contributor Author

Okay sure, I'll resubmit the pr.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants