This repository was archived by the owner on Jan 17, 2025. It is now read-only.
Fixed fatal error in PHP < 5.4 #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed fatal error in PHP < 5.4 due to unsupported syntax for defining an array (issue #46).
Closed
hugosolar
approved these changes
Mar 27, 2019
|
@all-contributors add @TheCrowned for code |
|
I've put up a pull request to add @TheCrowned! 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the fatal error reported in issue #46. The problem was due to the syntax used for defining an array in function
save_image_license_metadata(), where we didforeach ( ['license_url', 'attribution_url', 'source_work_url', 'extra_permissions_url'] as $field) {However, this compact syntax is only supported by PHP > 5.4. Officially, WordPress supports up to PHP 5.2, and since there is an equivalent syntax that works just the same, I updated the files to use the backwards-compatible one :)
foreach ( array( 'license_url', 'attribution_url', 'source_work_url', 'extra_permissions_url' ) as $field) {No change in function whatsoever, tested in my local setup by updating the license details of a media item and checking that they did indeed get through.