Skip to content
This repository was archived by the owner on Jan 17, 2025. It is now read-only.

Conversation

@hugosolar
Copy link
Contributor

Fixes #89
Fixes #87

Description

This pull request completely remove a set of options from prior versions of this plugin. This options was causing error in some cases (#87 for example) and this options are no longer available in the new versions

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the master branch of the repository.
  • My commit messages follow best practices.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@hugosolar hugosolar requested a review from a team as a code owner January 17, 2020 16:33
@hugosolar hugosolar requested a review from a team January 17, 2020 16:33
@hugosolar hugosolar self-assigned this Jan 17, 2020
@hugosolar hugosolar merged commit 05e7719 into master Jan 20, 2020
@TimidRobot TimidRobot deleted the remove-old-options branch January 29, 2020 16:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Non existent functions called and not-defined variables Error editing posts/pages when using Classic Editor plugin

4 participants