Skip to content

v2.0.0 #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 11, 2016
Merged

v2.0.0 #18

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
043ad50
v2.0.0
chris-pearce Aug 27, 2016
bf6f8d3
Removing forced line breaks
chris-pearce Aug 27, 2016
cc51e3e
Removing more forced line breaks
chris-pearce Aug 27, 2016
d768ed1
Adding a CHANGELOG
chris-pearce Sep 11, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removing forced line breaks
  • Loading branch information
@chris-pearce
chris-pearce committed Aug 27, 2016
commit bf6f8d3402f43ef36d16efbdd918845a562413cb
15 changes: 5 additions & 10 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -973,8 +973,7 @@ We use hyphen-delimited for:

### Namespace

Mostly everything in our CSS is namespaced so that our CSS is as transparent
and self-documenting as possible.
Mostly everything in our CSS is namespaced so that our CSS is as transparent and self-documenting as possible.

#### What We Namespace

Expand Down Expand Up @@ -1037,8 +1036,7 @@ And the rest:

Rather than rehashing everything about JS hooks let's instead defer to the [JavaScript Hooks](http://cssguidelin.es/#javascript-hooks) section in [Harry Roberts](http://csswizardry.com/) excellent [CSS Guidelines](http://cssguidelin.es/).

JS hooks—and [Server-side](#server-side-hooks), [QA](#qa-hooks), and [Tracking hooks](#tracking-hooks)—should always be scoped to the component it is part
off to avoid clashing with other hooks of the same category, and to keep them highly readable—not much different to how we structure our classes for styling.
JS hooks—and [Server-side](#server-side-hooks), [QA](#qa-hooks), and [Tracking hooks](#tracking-hooks)—should always be scoped to the component it is part off to avoid clashing with other hooks of the same category, and to keep them highly readable—not much different to how we structure our classes for styling.

###### :heavy_multiplication_x: NOT GOOD

Expand Down Expand Up @@ -1317,13 +1315,11 @@ Making it easier to apply our guidelines and to prevent wasting time picking apa

We recommend using the excellent [stylelint](http://stylelint.io/) CSS linter.

You'll be able to create a configuration file that enforces pretty much all
of these guidelines. Stand by for such a file.
You'll be able to create a configuration file that enforces pretty much all of these guidelines. Stand by for such a file.

### EditorConfig

We use an [EditorConfig](http://editorconfig.org) file which enforces our
indenting rules.
We use an [EditorConfig](http://editorconfig.org) file which enforces our indenting rules.

The contents of the `.editorconfig` file should look something like this:

Expand All @@ -1341,8 +1337,7 @@ insert_final_newline = true

### Text Editor Configuration

You should configure your text editor to adhere to as much of these guidelines
as possible.
You should configure your text editor to adhere to as much of these guidelines as possible.

At the bare minimum configure your editor to *show invisibles* or to automatically remove end-of-line whitespace.

Expand Down