Skip to content

Website version #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jakubpawlowicz opened this issue Jul 29, 2021 · 6 comments
Closed

Website version #2

jakubpawlowicz opened this issue Jul 29, 2021 · 6 comments
Labels
question Further information is requested

Comments

@jakubpawlowicz
Copy link
Contributor

Hey @johannchopin - should we bump package.json version when I update clean-css dependency minor version? No idea what would you prefer.
@jakubpawlowicz jakubpawlowicz added the question Further information is requested label Jul 29, 2021
@johannchopin
Copy link
Member

Hey 👋 I guess it's more clear to bump it so you don't need to check the yarn.lock file in case you want to be sure.

@jakubpawlowicz
Copy link
Contributor Author

👍 one more question - should I bump it to 1.0.1 when bumping clean-css to 5.1.4?

@johannchopin
Copy link
Member

Yes that will be more clean so I guess we also need to add a CHANGELOG file. I really like the keep a changelog convention to maintain history. Would it be ok for you to use that?

@jakubpawlowicz
Copy link
Contributor Author

👍 for changelog

@johannchopin
Copy link
Member

So I created the CHANGELOG.md file 👍 If you don't have other questions feel free to close this one 😄

@jakubpawlowicz
Copy link
Contributor Author

Nah, that's it, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jakubpawlowicz @johannchopin