Skip to content

New version with clean css 5.1.4 #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 29, 2021
Merged

New version with clean css 5.1.4 #3

merged 3 commits into from
Jul 29, 2021

Conversation

jakubpawlowicz
Copy link
Contributor

Please do not merge yet.

@johannchopin - do you know why my yarn.lock diff is so big? I generated it using npm 7.13.0 under node 16.2.0.

@johannchopin
Copy link
Member

@jakubpawlowicz Yes I build this project using yarn and not npm so could you use the yarn add ... command instead of npm i ...? If it's fine for you to use yarn instead of npm I will add a CONTRIBUTING file that specify it 👍

@jakubpawlowicz
Copy link
Contributor Author

Gotcha. I'm fine with yarn. Let me redo the PR.

@jakubpawlowicz
Copy link
Contributor Author

Should be fine now, can you check @johannchopin ?

Copy link
Member

@johannchopin johannchopin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR ✅ Actually it's my fault I didn't notice that there was still a package-lock file 😓 Could you please remove it real quick before merging the PR?

@jakubpawlowicz jakubpawlowicz merged commit c015d95 into main Jul 29, 2021
@jakubpawlowicz
Copy link
Contributor Author

All done.

@jakubpawlowicz jakubpawlowicz deleted the clean-css-5.1.4 branch July 29, 2021 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants