Fix HTTP client proxy support #742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the introduction of HTTP/2 support in the client, proxy handlers (requested via proxy-options) would be installed only after the HTTP version was negotiated. In case of a HTTPS connection, this would be attempted via ALPN which means the TLS handshake would have already taken place with the actual destination host, bypassing the configured proxy. This resulted in an error (see #731). With this patch, the proxy handlers are installed earlier again so that a configured proxy is also used during the TLS handshake phase.
Turns out this worked perfectly fine already.
|
FYI: There's a huge diff there due to wrapping + reindent, so I recommend to hide whitespace when looking at the diff once more! |
DerGuteMoritz
commented
Jan 23, 2025
KingMob
reviewed
Feb 9, 2025
KingMob
reviewed
Feb 9, 2025
KingMob
approved these changes
Feb 9, 2025
49cb9d2 to
d498758
Compare
arnaudgeiser
approved these changes
Feb 10, 2025
* Ensure that proxy connection errors have precedence over subsequent errors so that they don't get wrapped in e.g. SSL handshake exceptions. * Fix proxy connection timeout detection (the check wasn't correct anymore). * Propagate ProxyConnectionTimeoutException directly instead of wrapping it in another ConnectionTimeoutException * Add tests for proxy connection errors
KingMob
reviewed
Feb 12, 2025
|
Thanks for the great effort! I'm sorry that I didn't have time to contribute some tests. Maybe next time. Also congragulations to the 10²th tag and the 19²th closed issue! These are nice round numbers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #731