Fix a bug in converting ByteBuffers #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
9cac76e fixes an issue where the conversion of ByteBuffer -> (seq-of ByteBuffer) does not respect the position of the original buffer. Also, conversion behaves better when passing a chunk-size <= 0 (just returns an empty seq). |
consistent import formatting fix ByteBuffer -> (seq-of ByteBuffer) position bug remove accidental file cleanup tests
Contributor
Author
|
rebased. I had to change the type hint on |
Collaborator
|
Looks good, thanks. |
ztellman
added a commit
that referenced
this pull request
Jul 14, 2013
Fix a bug in converting ByteBuffers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The conversions for ByteBuffer -> byte array and seq-of ByteBuffer -> ByteBuffer incorrectly modifies the buffer's position. This fixes the issue and adds a test that fails without the fix.