-
Notifications
You must be signed in to change notification settings - Fork 32
Copy namespaces into clj-commons
and update primitive-math
dependency
#54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update primitive-math to use clj-commons.primitive-math in new nses.
8baa95b
to
700b3e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good so far. I have two requests:
- Can you add the :superseded-by and :no-doc metadata to the old namespaces?
- I don't think byte-streams is ready for 1.0.0 just yet. The next release will probably be 0.3.0, but for now, can you change the
:deprecated
value to justtrue
, and I'll update it when ready?
@KingMob sure no problem, I think I've updated all the namespaces as you describe. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Superseded is spelled without a "c" 😄
:superseded-by
@KingMob whoops! fixed |
Sweet! I’ll double-check this weekend when I’m free, but I think that’s it. |
Fixes issues with single segment namespaces.
Keep existing namespaces for compatibility.
Updates
primitive-math
dependency which was updated similarly in https://github.com/clj-commons/primitive-math/pull/14\Tests: