Skip to content

Copy namespaces into clj-commons and update primitive-math dependency #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 9, 2022

Conversation

skynet-gh
Copy link
Contributor

Fixes issues with single segment namespaces.
Keep existing namespaces for compatibility.

Updates primitive-math dependency which was updated similarly in https://github.com/clj-commons/primitive-math/pull/14\

Tests:

$ lein test
Compiling 3 source files to /home/skynet/git/byte-streams/target/classes

lein test byte-streams-simple-check
{:result true, :num-tests 10000, :seed 1649107149557, :time-elapsed-ms 594, :test-var "equivalent-comparison"}

lein test byte-streams-test

lein test clj-commons.byte-streams-simple-check
{:result true, :num-tests 10000, :seed 1649107189494, :time-elapsed-ms 372, :test-var "equivalent-comparison"}

lein test clj-commons.byte-streams-test

lein test pushback-stream-test

Ran 15 tests containing 1003 assertions.
0 failures, 0 errors

Update primitive-math to use clj-commons.primitive-math in new nses.
@skynet-gh skynet-gh force-pushed the copy-clj-commons-nses branch from 8baa95b to 700b3e4 Compare April 4, 2022 21:42
@skynet-gh skynet-gh marked this pull request as ready for review April 6, 2022 02:09
@skynet-gh skynet-gh requested a review from slipset as a code owner April 6, 2022 02:09
@KingMob KingMob requested review from KingMob and removed request for slipset April 6, 2022 09:47
Copy link
Collaborator

@KingMob KingMob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good so far. I have two requests:

  1. Can you add the :superseded-by and :no-doc metadata to the old namespaces?
  2. I don't think byte-streams is ready for 1.0.0 just yet. The next release will probably be 0.3.0, but for now, can you change the :deprecated value to just true, and I'll update it when ready?

@skynet-gh
Copy link
Contributor Author

@KingMob sure no problem, I think I've updated all the namespaces as you describe.

@skynet-gh skynet-gh requested a review from KingMob April 6, 2022 21:09
Copy link
Collaborator

@KingMob KingMob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superseded is spelled without a "c" 😄

:superseded-by

@skynet-gh
Copy link
Contributor Author

@KingMob whoops! fixed

@KingMob
Copy link
Collaborator

KingMob commented Apr 7, 2022

Sweet! I’ll double-check this weekend when I’m free, but I think that’s it.

@KingMob KingMob merged commit 2448108 into clj-commons:master Apr 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants