We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
That our current integration tests include the port in the :server-name:
:server-name
clj-http-lite/test/clj_http/test/core_test.clj
Lines 84 to 86 in 0219dc9
The we expect :server-port, and not as we see above :port.
:server-port
:port
clj-http-lite/src/clj_http/lite/core.clj
Lines 67 to 73 in 0219dc9
I'll fix that up. It happens to work, but it is not proper usage and misleading to anyone reading our tests.
The text was updated successfully, but these errors were encountered:
tests: server-name no longer includes port
4211246
Closes clj-commons#52
tests: server-name no longer includes port (#53)
58a8b3f
Closes #52
Successfully merging a pull request may close this issue.
I happened to notice...
That our current integration tests include the port in the
:server-name
:clj-http-lite/test/clj_http/test/core_test.clj
Lines 84 to 86 in 0219dc9
But this is because...
The we expect
:server-port
, and not as we see above:port
.clj-http-lite/src/clj_http/lite/core.clj
Lines 67 to 73 in 0219dc9
Soo...
I'll fix that up. It happens to work, but it is not proper usage and misleading to anyone reading our tests.
The text was updated successfully, but these errors were encountered: