Skip to content

Feature/fix insecure #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 31, 2020

Conversation

gaberger
Copy link

This PR updates handling requests for servers with self-signed certificates via the :insecure? option

Signed-off-by: Gary garyberger@forwardnetworks.com

Gary added 2 commits August 20, 2020 11:10
Signed-off-by: Gary <garyberger@forwardnetworks.com>
Signed-off-by: Gary <garyberger@forwardnetworks.com>
Copy link
Collaborator

@martinklepsch martinklepsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR Gary! Three questions:

  • Is this feature supported in clj-http?
  • Should we mention it in the README of this project?
  • Could you add a note to the CHANGELOG under "unreleased" or something like that?

Co-authored-by: Martin Klepsch <martinklepsch@googlemail.com>
@gaberger
Copy link
Author

clj-http already has insecure? support.
Yea I guess we nee to update the README and CHANGELOG will update.

Gary added 2 commits August 24, 2020 12:35
Signed-off-by: Gary <garyberger@forwardnetworks.com>
@martinklepsch martinklepsch merged commit febcad0 into clj-commons:master Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants