Skip to content

Cleanup project #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 16, 2021
Merged

Cleanup project #13

merged 10 commits into from
Jun 16, 2021

Conversation

vemv
Copy link
Collaborator

@vemv vemv commented Jun 9, 2021

Various things I did in preparation for #10. I tried to keep every commit semantic and reviewable on its own. They go as follows:

  • Remove unused ring/ring-devel
  • Mark :test dependencies as such
    • This tends to be cleaner - it's the "deps.edn" way, which we can follow even when using Lein :)
  • :test-selectors: default to running all tests
    • This is safer, especially for the CI integration.
  • Setup logging
    • This silences Jetty logging, which can be otherwise noisy, especially when using the :port 0 option.
  • Satisfy clj-kondo and Eastwood
  • Use randomized ports in tests
    • This yields an overall cleaner pattern, avoiding a defonce, possible interference with other processes, etc.
  • Remove some commented-out tests
    • Persistent HTTP connections are not supported (per Readme.md)
  • Enable test exercising :insecure? again
  • Remove references to unsupported :multipart option
  • Set up a test matrix
    • I tentatively changed the CI to Circle since it's better maintained and offers a native matrix syntax. Build is green in my account:

image

vemv added 9 commits June 8, 2021 23:54
This tends to be cleaner - it's the "deps.edn" way.
This is safer, especially for the CI integration.
This silences Jetty logging, which can be otherwise noisy, especially when using the `:port 0` option.
This yields an overall cleaner pattern, avoiding a defonce, possible interference with other processes, etc.
Persistent  HTTP connections are not supported (per Readme.md)
@vemv
Copy link
Collaborator Author

vemv commented Jun 15, 2021

@martinklepsch: looking good?

Copy link
Collaborator

@martinklepsch martinklepsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good indeed @vemv! Sorry for the delayed response here :)

Comment on lines 17 to 19
(let [resp (client/request (merge (base-req) {:uri "/get"
:method :get
:scheme "http"}))]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops! Amended

@martinklepsch
Copy link
Collaborator

I added you as a collaborator to this project. Please go ahead and merge this PR as your first action as a co-maintainer :)

@vemv vemv merged commit ffea820 into clj-commons:master Jun 16, 2021
@vemv vemv deleted the cleanup branch June 16, 2021 03:27
@vemv
Copy link
Collaborator Author

vemv commented Jun 16, 2021

Thanks! 🍻

I realised a bit too late that the .circleci file was redundant (in this PR I had noticed the Travis file but not the GH Actions file). Removed in master, improved the GH Actions as well to use a matrix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation has examples for multipart requests but they don't seem to work
2 participants