-
Notifications
You must be signed in to change notification settings - Fork 15
Cleanup project #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup project #13
Conversation
This tends to be cleaner - it's the "deps.edn" way.
This is safer, especially for the CI integration.
This silences Jetty logging, which can be otherwise noisy, especially when using the `:port 0` option.
This yields an overall cleaner pattern, avoiding a defonce, possible interference with other processes, etc.
Persistent HTTP connections are not supported (per Readme.md)
@martinklepsch: looking good? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good indeed @vemv! Sorry for the delayed response here :)
test/clj_http/test/client.clj
Outdated
(let [resp (client/request (merge (base-req) {:uri "/get" | ||
:method :get | ||
:scheme "http"}))] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indentation :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops! Amended
I added you as a collaborator to this project. Please go ahead and merge this PR as your first action as a co-maintainer :) |
Thanks! 🍻 I realised a bit too late that the .circleci file was redundant (in this PR I had noticed the Travis file but not the GH Actions file). Removed in master, improved the GH Actions as well to use a matrix |
Various things I did in preparation for #10. I tried to keep every commit semantic and reviewable on its own. They go as follows:
ring/ring-devel
:test-selectors
: default to running all tests:port 0
option.:insecure?
again