paredit: slurp fixes #359
Merged
paredit: slurp fixes #359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of #256, slurp fns had to be rewritten. During rewriting: - address design flaw by deprecating existing `slurp` fns and adding replacement `slurp-`*`-into` fns (closes #339) - stop adding space char when preserving slurped newlines (closes #345) - review ambiguous `-slurp-`*-`fully` fn behaviour (closes #341) - when slurping, don't consider a node with `#_` uneval nodes empty (closes #338) - don't throw on rewrite-clj parseable but invalid clojure `{:a}` (closes #336) - slurping forward fully no longer throws when slurping into an empty seq that is last item in a seq (closes #335) - slurping backward at empty-seq at start of seq no longer throws (closes #334) - slurp forward now slurps when at empty-seq at end of seq (closes #333)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of #256, slurp fns had to be rewritten. During rewriting:
slurpfns and adding replacementslurp-*-intofns (closes paredit design flawed around automatically slurping into empty seqs #339)-slurp-*-fullyfn behaviour (closes paredit/*-slurp-*-fully intended behaviour is ambiguous #341)#_uneval nodes empty (closes paredit considers a seq of #_uneval nodes empty #338){:a}(closes paredit fns throw on invalid clojure but valid rewrite-clj constructs #336)paredit/slurp-forward-fullythrows when slurping into an empty seq that is last item with a seq #335)