Most types of fields are gated so a missing key doesn't replace text with a blank, but not for spans#29
Closed
AdamMcCormick wants to merge 2 commits intocoderifous:masterfrom
Closed
Most types of fields are gated so a missing key doesn't replace text with a blank, but not for spans#29AdamMcCormick wants to merge 2 commits intocoderifous:masterfrom
AdamMcCormick wants to merge 2 commits intocoderifous:masterfrom
Conversation
Owner
|
Hi, Adam. Thanks for the pull-request. Can you please add a test for this change? |
Author
|
Sure, should be done later today |
Owner
|
Sorry, this pull request ended up being confusing. The ticket title mentioned tags, but the code change didn't have anything to do with span tags. The tests added seemed unrelated to the code change. The good news is that I think the essence of the issue was addressed in #37. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So this adds that gating for that case