Skip to content

Flexbox reference: tweaks to illustrations maybe #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fvsch opened this issue Jun 10, 2015 · 1 comment
Closed

Flexbox reference: tweaks to illustrations maybe #31

fvsch opened this issue Jun 10, 2015 · 1 comment
Assignees

Comments

@fvsch
Copy link

fvsch commented Jun 10, 2015

Hello,

I didn't have time to carefully read all the Flexbox reference at http://tympanus.net/codrops/css_reference/flexbox/, so I've mostly skimmed it, but I've noticed a few things with the illustrations:

Typos:

One imprecision:

  • flex-grow-illustration suggests that the values for the third example are: flex-grow: 0 for the first and last item, and flex-grow: 2 for the middle item. The text after the illustration makes it clear that the first and last items have flex-grow: 1, but the illustration can be misleading. My suggestion: add another line of text before the third example, so that the label reads:

flex-grow: 1 (all)
flex-grow: 2 (on second item)

Congrats again on all the excellent work in this reference.

@SaraSoueidan SaraSoueidan self-assigned this Jun 10, 2015
@crnacura
Copy link
Member

Thanks a lot, fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants