WarcCdxWriter: normalize URL of redirect target location#34
Merged
Conversation
Convert the redirect target location into an absolute URL and normalize the URL using the URL normalizer configured for scope "fetcher" before storing it as field "redirect" in the CDX file. Create all instances of SimpleDateFormat using the ROOT locale, use timezone "UTC" consistently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert the redirect target location into an absolute URL and normalize the URL using the URL normalizer configured for scope "fetcher" before storing it as field "redirect" in the CDX file.
This PR fixes a regression introduced with b3b78bb: redirect targets are not converted to absolute URLs. However, also normalization is required. Otherwise the redirect URLs in the URL index may include various representations of equivalent host names (upper/lower case, IDNs), or even different forms of URL path and query. Only URL normalization makes it possible to reliably follow redirects in the URL index.
Minor change: create all instances of SimpleDateFormat using the ROOT locale, and use the timezone "UTC" consistently.