Skip to content

Commit 11ff5fb

Browse files
authored
Fix NullPointer when clicking on image in MediaDetailFragment (#3730) (#3738)
Uri.parse would throw NullPointerException if the image in MediaDetailFragment was clicked before the image URL is available
1 parent dc6a3e5 commit 11ff5fb

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -222,10 +222,12 @@ && getParentFragment() instanceof MediaDetailPagerFragment) {
222222

223223
@OnClick(R.id.mediaDetailImageViewSpacer)
224224
public void launchZoomActivity(View view) {
225-
Context ctx = view.getContext();
226-
ctx.startActivity(
227-
new Intent(ctx,ZoomableActivity.class).setData(Uri.parse(media.getImageUrl()))
228-
);
225+
if (media.getImageUrl() != null) {
226+
Context ctx = view.getContext();
227+
ctx.startActivity(
228+
new Intent(ctx, ZoomableActivity.class).setData(Uri.parse(media.getImageUrl()))
229+
);
230+
}
229231
}
230232

231233
@Override

0 commit comments

Comments
 (0)