Skip to content

Commit 369fe31

Browse files
sivaraamneslihanturan
authored andcommitted
Give a useful label for the share intent (#1680)
It's better to give a useful label that would indicate what would happen when sharing using the app rather than letting it default to the app name.
1 parent b520bab commit 369fe31

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

app/src/main/AndroidManifest.xml

+2-2
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
android:name=".upload.ShareActivity"
4646
android:icon="@drawable/ic_launcher"
4747
android:label="@string/app_name">
48-
<intent-filter>
48+
<intent-filter android:label="@string/intent_share_upload_label">
4949
<action android:name="android.intent.action.SEND" />
5050
<category android:name="android.intent.category.DEFAULT" />
5151
<data android:mimeType="image/*" />
@@ -57,7 +57,7 @@
5757
android:name=".upload.MultipleShareActivity"
5858
android:icon="@drawable/ic_launcher"
5959
android:label="@string/app_name">
60-
<intent-filter>
60+
<intent-filter android:label="@string/intent_share_upload_label">
6161
<action android:name="android.intent.action.SEND_MULTIPLE" />
6262
<category android:name="android.intent.category.DEFAULT" />
6363
<data android:mimeType="image/*" />

app/src/main/res/values/strings.xml

+1
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
<string name="app_name">Commons</string>
88
<string name="bullet">&#8226; </string>
99
<string name="menu_settings">Settings</string>
10+
<string name="intent_share_upload_label">Upload to Commons</string>
1011
<string name="username">Username</string>
1112
<string name="password">Password</string>
1213
<string name="login_credential">Log in to your Commons Beta account</string>

0 commit comments

Comments
 (0)