Skip to content

Conversation

@sivaraam
Copy link
Member

Description (required)

It's better to give a useful label that would indicate what would
happen when sharing using the app rather than letting it default
to the app name.

Tests performed (required)

Tested on API 22 on Samsung Galaxy j1 ace with ProdDebug

Screenshots showing what changed (optional)

screenshot_2018-06-29-17-38-36

It's better to give a useful label that would indicate what would
happen when sharing using the app rather than letting it default
to the app name.
@codecov-io
Copy link

Codecov Report

Merging #1680 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1680   +/-   ##
======================================
  Coverage    3.85%   3.85%           
======================================
  Files         151     151           
  Lines        7599    7599           
  Branches      713     713           
======================================
  Hits          293     293           
  Misses       7289    7289           
  Partials       17      17

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0092451...783b695. Read the comment docs.

@neslihanturan
Copy link
Collaborator

Thanks @sivaraam ! This will be informative.

@neslihanturan neslihanturan merged commit 369fe31 into commons-app:master Jul 22, 2018
@sivaraam sivaraam deleted the give-useful-intent-label branch February 8, 2020 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants