Fix achievements response parsing (#2323)

maskaravivek · misaochan · commit 53e186df9a7b · 2019-01-24T18:20:41.000+10:00
diff --git a/app/src/main/java/fr/free/nrw/commons/mwapi/ApacheHttpClientMediaWikiApi.java b/app/src/main/java/fr/free/nrw/commons/mwapi/ApacheHttpClientMediaWikiApi.java
@@ -995,9 +995,9 @@ public Single<FeedbackResponse> getAchievements(String userName) {
                 if (json == null) {
                     return null;
                 }
-                Timber.d(json);
+                Timber.d("Response for achievements is %s", json);
                 try {
-                    return gson.fromJson(String.valueOf(response.body()), FeedbackResponse.class);
+                    return gson.fromJson(json, FeedbackResponse.class);
                 }
                 catch (Exception e){
                     return new FeedbackResponse("",0,0,0,new FeaturedImages(0,0),0,"",0);

Original file line number	Diff line number	Diff line change
`@@ -995,9 +995,9 @@ public Single<FeedbackResponse> getAchievements(String userName) {`
`995`	`995`	`if (json == null) {`
`996`	`996`	`return null;`
`997`	`997`	`}`
`998`		`- Timber.d(json);`
	`998`	`+ Timber.d("Response for achievements is %s", json);`
`999`	`999`	`try {`
`1000`		`- return gson.fromJson(String.valueOf(response.body()), FeedbackResponse.class);`
	`1000`	`+ return gson.fromJson(json, FeedbackResponse.class);`
`1001`	`1001`	`}`
`1002`	`1002`	`catch (Exception e){`
`1003`	`1003`	`return new FeedbackResponse("",0,0,0,new FeaturedImages(0,0),0,"",0);`