Skip to content

Fix achievements response parsing #2323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2019

Conversation

maskaravivek
Copy link
Member

Description (required)

Fixes #2271
Fixes #2284

What changes did you make and why?

There was some issue with how the JSON was getting parsed. The issue was introduced in #2287.

Tests performed (required)

prodDebug

Screenshots showing what changed (optional - for UI changes)

device-2019-01-20-015422

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@aac0b7c). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #2323   +/-   ##
========================================
  Coverage          ?   5.89%           
========================================
  Files             ?     237           
  Lines             ?   11354           
  Branches          ?    1020           
========================================
  Hits              ?     669           
  Misses            ?   10633           
  Partials          ?      52
Impacted Files Coverage Δ
...rw/commons/mwapi/ApacheHttpClientMediaWikiApi.java 3.94% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aac0b7c...889d1f6. Read the comment docs.

@misaochan misaochan merged commit 53e186d into commons-app:master Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants