Skip to content

Commit 9bd5834

Browse files
committed
Change hardcoded strings in the language search dialog to messages
Another comment: While working on this, I also noticed that "Recent Searches" is hardcoded in the XML file, and I'm not sure where does it actually appear. I fixed it, too, but perhaps it can be completely removed. Fixes #6439.
1 parent 10c384f commit 9bd5834

File tree

3 files changed

+9
-3
lines changed

3 files changed

+9
-3
lines changed

app/src/main/res/layout/dialog_select_language.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
android:layout_marginStart="8dp"
1313
android:layout_marginTop="8dp"
1414
android:layout_marginEnd="8dp"
15-
android:hint="Type Language Name"
15+
android:hint="@string/language_search_type_language_name"
1616
android:padding="12dp"
1717
app:layout_constraintEnd_toEndOf="parent"
1818
app:layout_constraintStart_toStartOf="parent"
@@ -22,7 +22,7 @@
2222
android:id="@+id/recent_searches"
2323
android:layout_width="0dp"
2424
android:layout_height="wrap_content"
25-
android:text="Recent Searches"
25+
android:text="@string/language_search_recent_searches"
2626
app:layout_constraintTop_toBottomOf="@id/search_language"
2727
app:layout_constraintEnd_toEndOf="@+id/language_history_list"
2828
android:layout_marginEnd="8dp"
@@ -55,7 +55,7 @@
5555
android:id="@+id/all_languages"
5656
android:layout_width="0dp"
5757
android:layout_height="wrap_content"
58-
android:text="All Languages"
58+
android:text="@string/language_search_all_languages"
5959
app:layout_constraintTop_toBottomOf="@id/separator"
6060
app:layout_constraintEnd_toEndOf="@+id/language_history_list"
6161
android:layout_margin="8dp"

app/src/main/res/values-qq/strings.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,9 @@
9797
<string name="no_uploads_yet">Message shown on contribution list during non-first sync if no uploads present.</string>
9898
<string name="menu_retry_upload">Menu item text prompting user to retry a failed upload.\n{{Identical|Retry}}</string>
9999
<string name="menu_cancel_upload">Menu item text prompting user to cancel and delete a failed upload.\n{{Identical|Cancel}}</string>
100+
<string name="language_search_type_language_name">Placeholder text in the top search box in the language search dialog.</string>
101+
<string name="language_search_recent_searches">A title in the language search dialog.</string>
102+
<string name="language_search_all_languages">A title in the language search dialog.</string>
100103
<string name="menu_download">Menu item text prompting user to download a selected photo or media file locally.\n{{Identical|Download}}</string>
101104
<string name="preference_license">{{Identical|License}}</string>
102105
<string name="use_previous">This is a button text. Concise wording is preferred (e.g. \"&amp;\" instead of \"and\"), where possible. It should ideally be rendered in one line, even on small devices.</string>

app/src/main/res/values/strings.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -150,6 +150,9 @@
150150
<string name="no_uploads_yet">You have not yet uploaded any photos.</string>
151151
<string name="menu_retry_upload">Retry</string>
152152
<string name="menu_cancel_upload">Cancel</string>
153+
<string name="language_search_type_language_name">Type Language Name</string>
154+
<string name="language_search_recent_searches">Recent Searches</string>
155+
<string name="language_search_all_languages">All Languages</string>
153156
<string name="media_upload_policy">By submitting this picture, I declare that this is my own work, that it does not contain copyrighted material or selfies, and otherwise adheres to &lt;a href=\"https://commons.wikimedia.org/wiki/Commons:Policies_and_guidelines\"&gt;Wikimedia Commons policies&lt;/a&gt;.</string>
154157
<string name="menu_download">Download</string>
155158
<string name="preference_license">Default License</string>

0 commit comments

Comments
 (0)