Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: commons-app/apps-android-commons
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v5.3.0
Choose a base ref
...
head repository: commons-app/apps-android-commons
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v5.4.0-beta
Choose a head ref
  • 17 commits
  • 58 files changed
  • 10 contributors

Commits on Apr 14, 2025

  1. Configuration menu
    Copy the full SHA
    1a13cb3 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2025

  1. FIX : Custom picker detect images that is already in commons (#6288)

    * Fix: Exclude specific text from being posted in WikidataFeedback
    
    * Add detection logic for images already on Commons in custom picker
    sonalyadav1 authored Apr 15, 2025
    Configuration menu
    Copy the full SHA
    78d29bc View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2025

  1. Configuration menu
    Copy the full SHA
    ed42d85 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2025

  1. Code Enhancement (Explore Map) (#6293)

    * Exclude past locations (P585) from Nearby query
    
    * "Send" button text should be white
    
    * Custom picker: logic
    
    * Revert back changes
    
    * Enhancement :- Explore Map information
    
    * Enhancement :- Explore Map information
    
    * Style
    
    ---------
    
    Co-authored-by: Nicolas Raoul <nicolas.raoul@gmail.com>
    khushbuk0711 and nicolas-raoul authored Apr 21, 2025
    Configuration menu
    Copy the full SHA
    7479d96 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3076297 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2025

  1. Improve credit line in image list (#6295)

    - When author is not uploader, show both.
    - When failing to parse author from HTML, use structured data.
    whym authored Apr 23, 2025
    Configuration menu
    Copy the full SHA
    329a682 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2025

  1. Configuration menu
    Copy the full SHA
    8fded5e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d0f6c16 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2025

  1. Configuration menu
    Copy the full SHA
    60aca9a View commit details
    Browse the repository at this point in the history

Commits on May 1, 2025

  1. Configuration menu
    Copy the full SHA
    0024e72 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2025

  1. Configuration menu
    Copy the full SHA
    4d21702 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2025

  1. Configuration menu
    Copy the full SHA
    865824a View commit details
    Browse the repository at this point in the history

Commits on May 8, 2025

  1. Configuration menu
    Copy the full SHA
    f06ae4e View commit details
    Browse the repository at this point in the history

Commits on May 9, 2025

  1. Configuration menu
    Copy the full SHA
    3f2077a View commit details
    Browse the repository at this point in the history

Commits on May 10, 2025

  1. Fixes Issue 6262: [Bug]: Error occurred while loading images (#6291)

    * ImageInfo.kt: remove call to updateThumbURL()
    
    Before this commit, the updateThumbURL() method would attempt to derive a larger resolution thumbnail URL
    from the current thumbnail's width and height. This derived thumbnail URL would sometimes not match
    an actual URL. Even creating this thumbnail URL would sometimes fail when doing string manipulation.
    Both errors can cause issues, with the second one crashing the thread and preventing images from being
    loaded.
    
    This commit simply removes the call to updateThumbURL(). Images with their thumbnails now load correctly,
    especially with panoramic images.
    
    * MediaInterface.kt: fix MediaWiki API call to retrieve thumbnail URLs properly
    
    Before this change, the API calls to MediaWiki would request thumbnails with atleast a specific width,
    rather than height. These thumbnails would often be extremely low resolution on very wide images,
    such as panoramas.
    
    This change instead requests thumbnails with atleast a specific height. Panorama thumbnails are now
    at a higher resolution than before. Additionally, the height parameter is now represented as an
    integer which can be changed more easily.
    
    * ViewPagerAdapter.java: create new constructor with behavior parameter
    
    Before this commit, ViewPagerAdapter only had one constructor which used the default
    behavior where more than the current fragment would be in the Resume state.
    
    This commit adds a constructor where the behavior parameter can be specified.
    
    * ExploreFragment.java: modify onCreateView to use new ViewPagerAdapter constructor
    
    Before this change, onCreateView would use the old ViewPagerAdapter constructor, which
    had a default behavior where fragments not currently visible would be in the Resume
    state.
    
    After this change, the new ViewPagerAdapter constructor is used with a non-default
    behavior where only the visible fragment would be in the Resume state. This has
    performance benefits for most users since the Fragments will only be active
    when they want to view them.
    
    * ExploreMapFragment.java: remove redundant method call
    
    Before this commit, performMapReadyActions() was called in both onViewCreated and onResume.
    In effect, the method is called twice before the user can even see the map, leading to
    performance issues.
    
    After this commit, the call in onViewCreated is removed. The method is now called only once
    when the user switches to the ExploreMapFragment.
    
    * ExploreMapFragment.java: remove method call that causes recursive loop
    
    Before this commit, there was a call loop that included onScroll and animateTo
    on the map. These two method calls caused performance issues in
    ExploreMapFragment.
    
    This commit breaks the call loop by removing moveCameraToPosition from getMapCenter.
    Also, the removed code did not fit the purpose of getMapCenter.
    
    * ExploreMapFragment.java: fix performMapReadyActions to center to user's last known location
    
    Before this commit, fixing a previous bug caused performMapReadyActions to center the map
    on a default location rather than the available last known location.
    
    This commit adds code which will attempt to get the last known user location. If it cannot
    be retrieved, the default location is used. The map now centers properly.
    
    * MediaInterface.kt: adjust thumbnail height parameter
    
    Before this commit, the thumbnail height parameter was too small, causing low resolution thumbnails to render.
    
    This commit more than doubles the parameter, increasing the thumbnail resolution.
    
    ---------
    
    Co-authored-by: Ritika Pahwa <83745993+RitikaPahwa4444@users.noreply.github.com>
    Co-authored-by: Nicolas Raoul <nicolas.raoul@gmail.com>
    3 people authored May 10, 2025
    Configuration menu
    Copy the full SHA
    0120207 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2025

  1. Configuration menu
    Copy the full SHA
    f977e16 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2025

  1. Configuration menu
    Copy the full SHA
    21ffcb5 View commit details
    Browse the repository at this point in the history
Loading