Skip to content

Black background on details and categories screen #1004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nicolas-raoul opened this issue Dec 6, 2017 · 4 comments
Closed

Black background on details and categories screen #1004

nicolas-raoul opened this issue Dec 6, 2017 · 4 comments

Comments

@nicolas-raoul
Copy link
Member

nicolas-raoul commented Dec 6, 2017

A student with an Android 4.2.2 Samsung Galaxy GT-S7583T always gets a black background at the details and categories screens:

More screenshots with 3 different pictures: https://github.com/commons-app/apps-android-commons/tree/master/design/screenshots/Hebrew%20iw-IL
Might be due to relatively low RAM (0.75 GB). Black background is better than crashing, so it is not high-priority. That phone should definitely be able to load the picture though, so we are probably trying to load it in a memory-inefficient way (I assume the same pictures show up fine at the same size in the Android stock gallery). Actually I got this same problem when trying to upload a very heavy picture.

I left it sitting on the category search for hours once, and the picture never showed up there...

@superplane39
Copy link
Contributor

I'm the student who encountered the problem; I'd be interested in helping out, if possible, and help test issues :)

@harisankerPradeep
Copy link
Contributor

I feel that downsampling and resizing functions of fresco, given here, can solve this issue. For example, my screen resolution is 720x1280 and the maximum resolution of my camera is 3280x2160. Knowing this I should be able to resize the image without any loss in quality of the displayed picture, right? Or am I getting this wrong somewhere?

Thanks in advance!

@nicolas-raoul
Copy link
Member Author

Resizing is definitely the best way to solve this problem, indeed.
This background image feature might be removed in the future (see #1044), but if it is easy and safe then feel free to implement it @harisankerPradeep :-)

@harisankerPradeep
Copy link
Contributor

@nicolas-raoul From what I can see in the fresco docs it seems simple and safe. I'll post some updates soon enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants