Skip to content

Preview image in ShareActivity fails to load #1175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
harisankerPradeep opened this issue Feb 21, 2018 · 3 comments
Closed

Preview image in ShareActivity fails to load #1175

harisankerPradeep opened this issue Feb 21, 2018 · 3 comments

Comments

@harisankerPradeep
Copy link
Contributor

Sometimes when the selected image is heavy the preview image in ShareActivity, the one that appears in the background of the title and descriptions screen, fails to load. This mostly happens when the camera operates at maximum resolution. If the resolution of the image is a couple of notches lower it loads just fine.

Observed

godavnvis

Expected (This was achieved by clicking the same photo at a lower resolution using open camera)

godavvis

Device and Android version:
Xiaomi Redmi 4A, Android 6.0.1, MIUI 8.5.7.0

Solution: I think most of this can be solved by using downsampling and resizing functions of fresco given here . I also came across #889 which intents to replace fresco with glide.

I'd like to work on this if the community feels it's a good idea.

Cheers!

@nicolas-raoul
Copy link
Member

I can confirm this problem.
Is it not a duplicate of #1004 though?

@harisankerPradeep
Copy link
Contributor Author

harisankerPradeep commented Feb 22, 2018

@nicolas-raoul My bad, it's same as #1004. But I strongly feel about downsampling and resizing because my screen resolution is 720x1280 and the maximum resolution of my camera is 3280x2160. Knowing this I should be able to resize the image without any loss in quality of the displayed picture, right? Or am I getting this wrong somewhere?
Also should I move this conversation to #1004 ?

Thanks in advance!

@nicolas-raoul
Copy link
Member

Closing as duplicate of #1004.
Yes, please copy/paste your comment there, thanks :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants