-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fix string resource values with '%s' #1112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Working on it. |
I thought it was fixed but apparently it wasn't. https://travis-ci.org/commons-app/apps-android-commons/builds/336021170 It looks like the recent translation update brought new entries with the same problem. |
I think the problem was that I forgot to clean and rebuild before merging. Because I don't see any of these complaints in the XML files. |
Is someone working on this issue? This task fails while trying to build.
|
Am not sure if anyone is fixing it currently. Am taking this up. |
Uh oh!
There was an error while loading. Please reload this page.
It looks like the values with '%s' in 28a6a3b caused compilation errors in 72cddbf . The problem is that apparently translatewiki.net cannot preserve the 'formatted="false"' attribute.
However, even if translatewiki.net supports it, should they be replaced with positional arguments anyway? I think sometimes translation may break the ordering of arguments. (I mean argument_index in https://developer.android.com/reference/java/util/Formatter.html by 'positional arguments'.)
The text was updated successfully, but these errors were encountered: