Skip to content

Fix string resource values with '%s' #1112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
whym opened this issue Jan 29, 2018 · 5 comments
Closed

Fix string resource values with '%s' #1112

whym opened this issue Jan 29, 2018 · 5 comments
Assignees

Comments

@whym
Copy link
Collaborator

whym commented Jan 29, 2018

It looks like the values with '%s' in 28a6a3b caused compilation errors in 72cddbf . The problem is that apparently translatewiki.net cannot preserve the 'formatted="false"' attribute.

However, even if translatewiki.net supports it, should they be replaced with positional arguments anyway? I think sometimes translation may break the ordering of arguments. (I mean argument_index in https://developer.android.com/reference/java/util/Formatter.html by 'positional arguments'.)

@cfva14
Copy link
Contributor

cfva14 commented Jan 31, 2018

Working on it.

@whym whym closed this as completed Feb 1, 2018
@whym
Copy link
Collaborator Author

whym commented Feb 1, 2018

I thought it was fixed but apparently it wasn't. https://travis-ci.org/commons-app/apps-android-commons/builds/336021170

It looks like the recent translation update brought new entries with the same problem.

@whym whym reopened this Feb 1, 2018
@cfva14
Copy link
Contributor

cfva14 commented Feb 1, 2018

I think the problem was that I forgot to clean and rebuild before merging. Because I don't see any of these complaints in the XML files.

@maskaravivek
Copy link
Member

Is someone working on this issue? This task fails while trying to build.

./gradlew :app:processBetaDebugResources

@maskaravivek
Copy link
Member

Am not sure if anyone is fixing it currently. Am taking this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants