Skip to content

Korean translation in values causes Android Studio to fail building #1135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Moseco opened this issue Feb 12, 2018 · 6 comments
Closed

Korean translation in values causes Android Studio to fail building #1135

Moseco opened this issue Feb 12, 2018 · 6 comments

Comments

@Moseco
Copy link
Contributor

Moseco commented Feb 12, 2018

I was looking into contributing to this project and when I cloned and built the project I ran into a problem.
Gradle tells me that values-ko-kp is an invalid directory. Travis also seems to output the same error.
Looking into the language and resource section of the Android documentation the Korean letter code "ko" is the accepted one.

Is there something I am missing to get this to build correctly or should that folder not be there when it was added in this commit.

@Moseco
Copy link
Contributor Author

Moseco commented Feb 12, 2018

Looking further into it, it seems that adding the additional language code "kp" requires it to have a proceeding "r". Changing the directory from "values-ko-kp" to "values-ko-rkp" makes the build work and follows the documentation on additional language codes.

Ive made a pull request here

@Moseco Moseco changed the title Trouble building project in Android Studio Korean translation in values causes Android Studio to fail building Feb 12, 2018
@misaochan
Copy link
Member

Thanks for reporting this! We will probably need to get @Nikerabbit to review your PR before we patch it. AFAIK if the appropriate changes are not made on translatewiki's side, future commits will continue to introduce the error.

@Nikerabbit
Copy link
Contributor

Shouldn't it be ko-rKP to match zh-rTW?

Also, why is there zh-rCN? No such language is configured from our side. zh-hans maps to zh

@Moseco
Copy link
Contributor Author

Moseco commented Feb 14, 2018

For consistency rKP would probably be better. rkp does work though.

@Nikerabbit
Copy link
Contributor

Nikerabbit commented Feb 15, 2018

I've set codemap to use ko-rKP. https://gerrit.wikimedia.org/r/c/410406/

@ujjwalagrawal17
Copy link
Contributor

I think it should be closed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants