Add Share app option inside app

[ujjwalagrawal17]

Summary:

There should be an option to share the app.

Steps to reproduce:

1. Add option to share in navigation drawer.
2. On Click of share option -

Intent sendIntent = new Intent();
sendIntent.setAction(Intent.ACTION_SEND);
sendIntent.putExtra(Intent.EXTRA_TEXT, "sharetext");
sendIntent.setType("text/plain");
startActivity(Intent.createChooser(sendIntent, getString(R.string.share)));

Expected behavior:
There should be an option to share the app.

Observed behavior:
There is no option to share the app.

Commons app version:
2.6.7

[ujjwalagrawal17]

Share text can be
Upload photos to Wikimedia Commons using the app.
Download Now: Google play link

I need some suggestions for the text

[maskaravivek]

This enhancement looks good to me. Let's wait for others to pitch in before starting work on it. :)

[misaochan]

Looks good to me, but I would probably put this in About instead of the nav drawer. Nav drawer is getting quite full. ;) I also think the text should be:

Upload photos to Wikimedia Commons on your phone
Download the Commons app: Google play link

[nicolas-raoul]

Could you please post screenshots of a few popular apps that have a similar feature? Thanks!

[ujjwalagrawal17]

Screenshots from Phimp.me

[aniket1897]

I have worked on this issue can I submit PR?

[ujjwalagrawal17]

@aniket1897 I wanted to work on it. You should ask before working on the issue.
But since you had already worked on it. You submit the PR.

[aniket1897]

Sorry @ujjwalagrawal17 new to open source , next time I will take care.

[maskaravivek]

@nicolas-raoul @misaochan Your opinions on whether we need this feature? :)

[misaochan]

I definitely think it should NOT be in the navigation drawer the way the app in the screenshot does it. Feels a lot like feature bloat and users might get annoyed, since it isn't really something they would use often.

However, I think it could be nice to have a little "Share" icon in About. Perhaps next to the FB etc icons?

[maskaravivek]

Keeping the share button in the top bar (Toolbar) of the About page also seems to be a good idea to me. That way it won't get lost in the already overcrowded About page.

[misaochan]

@maskaravivek Sounds like a plan! 👍