-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Dividing nav bar into sections. #1317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
What sections do you suggest?
…On Fri, Mar 16, 2018 at 3:55 PM, Jatin0312 ***@***.***> wrote:
*Summary:*
1. We can divide navbar into section as it would look better than the
existing nav bar.
*Expected behavior:*
[image: navbar2]
<https://user-images.githubusercontent.com/17095817/37507407-57448cf6-2914-11e8-919b-bd31e2d9ec2e.jpeg>
It's just a sample from fasthub application.
*Observed behavior:*
[image: navbar]
<https://user-images.githubusercontent.com/17095817/37507520-e1bf9222-2914-11e8-9d88-e48c1e1d344c.jpeg>
*Device and Android version:*
Moto g4 plus
Android 7.0.0
*Commons app version:*
2.6.7
*Would you like to work on the issue?*
Yes, I would like to work on this issue.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1317>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAGFBldhPJsEcQahv12rXygedHUFfu2qks5te2HRgaJpZM4StU7C>
.
|
We can divide section into 3 parts
These are just suggestions we can change it accordingly. |
@Jatin0312 I don't think it is required, the navigation bar looks good. |
How do you plan on organizing the current nav bar? I am open to this if the organization makes sense. :) We should probably ask @neslihanturan though. |
I think organization is a good idea since we have several items. But I don't think suggested organisation is a good idea. My suggestion is:
|
I think @neslihanturan organization suggestion given by you is really nice :) |
Hi @neslihanturan if this organisation is Ok should I create a PR for this. |
Sorry, I missed this one somehow :( Waiting for your PR @Jatin0312 |
Fix for issue #1317 Dividing nav bar into sections
Summary:
Expected behavior:
It's just a sample from fasthub application.
Observed behavior:
Device and Android version:
Moto g4 plus
Android 7.0.0
Commons app version:
2.6.7
Would you like to work on the issue?
Yes, I would like to work on this issue.
The text was updated successfully, but these errors were encountered: