Skip to content

Dividing nav bar into sections. #1317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Jatin0312 opened this issue Mar 16, 2018 · 9 comments
Closed

Dividing nav bar into sections. #1317

Jatin0312 opened this issue Mar 16, 2018 · 9 comments

Comments

@Jatin0312
Copy link
Contributor

Summary:

  1. We can divide navbar into section as it would look better than the existing nav bar.

Expected behavior:

navbar2

It's just a sample from fasthub application.

Observed behavior:

navbar

Device and Android version:

Moto g4 plus
Android 7.0.0

Commons app version:

2.6.7

Would you like to work on the issue?

Yes, I would like to work on this issue.

@nicolas-raoul
Copy link
Member

nicolas-raoul commented Mar 16, 2018 via email

@Jatin0312
Copy link
Contributor Author

We can divide section into 3 parts

  1. First section containing Home
  2. Second section containing Nearby, Notification and Tutorial
  3. Third section containing About, Settings, Feedback and logout

These are just suggestions we can change it accordingly.

@madhurgupta10
Copy link
Collaborator

@Jatin0312 I don't think it is required, the navigation bar looks good.

@misaochan
Copy link
Member

How do you plan on organizing the current nav bar?

I am open to this if the organization makes sense. :) We should probably ask @neslihanturan though.

@neslihanturan
Copy link
Collaborator

I think organization is a good idea since we have several items. But I don't think suggested organisation is a good idea. My suggestion is:

  • Our main features are home and nearby.
  • Account or app related things are notifications, settings and logout (Logout should be at the end of everything)
  • Information and communication with developers things about, tutorial and feedback

@Jatin0312
Copy link
Contributor Author

I think @neslihanturan organization suggestion given by you is really nice :)
Just in case for Logout we can create separate section since it should be kept at last.

@Jatin0312
Copy link
Contributor Author

It would look something like this:

Screenshots
nav5

@Jatin0312
Copy link
Contributor Author

Hi @neslihanturan if this organisation is Ok should I create a PR for this.
Thanks :)

@neslihanturan
Copy link
Collaborator

Sorry, I missed this one somehow :( Waiting for your PR @Jatin0312

Jatin0312 added a commit to Jatin0312/apps-android-commons that referenced this issue Mar 21, 2018
misaochan added a commit that referenced this issue Mar 25, 2018
Fix for issue #1317 Dividing nav bar into sections
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants